refactor: migrate theme system to native macOS patterns#805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NSColorequivalents (labelColor,separatorColor,controlBackgroundColor, etc.) instead of hardcoded hex. They adapt automatically to light/dark mode, system accent color, and high contrast settings. Custom themes can still override with hex values.ThemeEngine.shared.activeTheme.typography.*across 65 files with SwiftUI semantic text styles (.body,.caption,.subheadline,.callout,.title3,.title2) for proper Dynamic Type and accessibility support.ThemeTypography,ThemeSpacing,ThemeCornerRadius,ThemeIconSizes,ThemeRowHeights,ThemeAnimationsstructs and the Layout tab from the theme editor. Spacing/radius/icon values replaced with literals.EmptyStateViewnow wrapsContentUnavailableView(macOS 14+).UserDefaults.synchronize(), fixedVimRegisterpasteboard side-effect indidSet(now explicitsyncToPasteboard()), fixedAboutWindowControllerpanel memory retention.93 files changed, 623 insertions, 1190 deletions.
Test plan
yy), paste in external app — pasteboard sync should work